-
Notifications
You must be signed in to change notification settings - Fork 5.3k
In reset_memory, check settings.entry_memory_load ... #58350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
In reset_memory, check settings.entry_memory_load ... #58350
Conversation
…w_memory_status - it looks like the latter won't be set on Linux.
|
Tagging subscribers to this area: @dotnet/gc Issue Detailsin addition to g_low_memory_status - it looks like the latter is only set in response to low memory notifications from the OS - looks like this won't happen on Linux. This may also impact issue #52592 depending on actual memory load.
|
Maoni0
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should make a helper function for this as we now have a few places that do exactly this.
|
Makes sense - done. |
Maoni0
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a minor comment - I would add this as a static method in gc_heap next to all the dt_* methods since this is of the exact nature as those methods (ie, dt_high_memory_load_p)
…_high_memory_load_p.
|
/backport to release/6.0 |
|
Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/1193591264 |
in addition to g_low_memory_status - it looks like the latter is only set in response to low memory notifications from the OS - looks like this won't happen on Linux. This may also impact issue #52592 depending on actual memory load.