Skip to content

Conversation

@PeterSolMS
Copy link
Contributor

in addition to g_low_memory_status - it looks like the latter is only set in response to low memory notifications from the OS - looks like this won't happen on Linux. This may also impact issue #52592 depending on actual memory load.

…w_memory_status - it looks like the latter won't be set on Linux.
@ghost ghost added the area-GC-coreclr label Aug 30, 2021
@ghost
Copy link

ghost commented Aug 30, 2021

Tagging subscribers to this area: @dotnet/gc
See info in area-owners.md if you want to be subscribed.

Issue Details

in addition to g_low_memory_status - it looks like the latter is only set in response to low memory notifications from the OS - looks like this won't happen on Linux. This may also impact issue #52592 depending on actual memory load.

Author: PeterSolMS
Assignees: -
Labels:

area-GC-coreclr

Milestone: -

Copy link
Member

@Maoni0 Maoni0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should make a helper function for this as we now have a few places that do exactly this.

@PeterSolMS
Copy link
Contributor Author

Makes sense - done.

Copy link
Member

@Maoni0 Maoni0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a minor comment - I would add this as a static method in gc_heap next to all the dt_* methods since this is of the exact nature as those methods (ie, dt_high_memory_load_p)

@PeterSolMS PeterSolMS merged commit 267d98d into dotnet:main Sep 1, 2021
@PeterSolMS
Copy link
Contributor Author

PeterSolMS commented Sep 2, 2021

/backport to release/6.0

@github-actions
Copy link
Contributor

github-actions bot commented Sep 2, 2021

@ghost ghost locked as resolved and limited conversation to collaborators Oct 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants