Skip to content

Conversation

@antonfirsov
Copy link
Contributor

We need this to make sure that NCL is stable for 6.0.

@dotnet/dncenghot is this the right way to setup this? If not can you please help?

@ghost
Copy link

ghost commented Aug 27, 2021

Tagging subscribers to this area: @Anipik, @safern, @ViktorHofer
See info in area-owners.md if you want to be subscribed.

Issue Details

We need this to make sure that NCL is stable for 6.0.

@dotnet/dncenghot is this the right way to setup this? If not can you please help?

Author: antonfirsov
Assignees: -
Labels:

area-Infrastructure-libraries

Milestone: -

@lpatalas
Copy link

@antonfirsov, I think you should merge it to release/6.0 branch otherwise the trigger won't be added. Your scenario is described at the end of this doc section: Branch considerations for scheduled triggers

It says something like this:

Because release was added to the branch filters in the main branch, but not to the branch filters in the release branch, the release branch won't be built on that schedule. Only when the feature branch is added to the branch filters in the YAML file in the feature branch will the scheduled build be added to the scheduler.

@antonfirsov
Copy link
Contributor Author

@lpatalas thank you!

@dotnet/ncl mergig Merging this directly to release/6.0 seems messy to me. I think the best would be to merge & backport this so keep the YAML-s in sync, and have a reminder on main that these pipelines are scheculed against release/6.0.

@antonfirsov antonfirsov requested a review from a team August 27, 2021 14:27
@antonfirsov

This comment has been minimized.

@azure-pipelines

This comment has been minimized.

Copy link
Member

@ManickaP ManickaP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I cannot speak for the infra part (where to merge etc.).
Thanks for this!

@karelz karelz added this to the 7.0.0 milestone Aug 27, 2021
@antonfirsov
Copy link
Contributor Author

HTTP 1.1 CI stress run hasn't finished yet, but from the logs it's clear that the changes have no negative impact, merging.

@antonfirsov antonfirsov merged commit 7384e0a into dotnet:main Aug 27, 2021
@antonfirsov
Copy link
Contributor Author

/backport to release/6.0

@github-actions
Copy link
Contributor

@ghost ghost locked as resolved and limited conversation to collaborators Sep 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants