Fix trim_youngest_desired #58180
Fix trim_youngest_desired #58180
Conversation
…ain memory - the return value should never be larger than total_new_allocation.
|
Tagging subscribers to this area: @dotnet/gc Issue DetailsThe case where we have high memory load and huge main memory can cause the return value to be larger than total_new_allocation. As it turns out, this is contributing to issue #52592 - gen 0 budget shoots upruptly to 5.1 GB and drops back.
|
| { | ||
| return max (mem_one_percent, total_min_allocation); | ||
| size_t total_max_allocation = max (mem_one_percent, total_min_allocation); | ||
| return min (total_new_allocation, total_max_allocation); |
There was a problem hiding this comment.
have we figured out a way to validate such changes? Would the tuning simulator help in such cases?
There was a problem hiding this comment.
yes, I think we should totally add budget calculation to the tuning simulator.
|
/backport to release/6.0 |
|
Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/1193243177 |
ghost
locked as resolved and limited conversation to collaborators
3 participants
The case where we have high memory load and huge main memory can cause the return value to be larger than total_new_allocation.
As it turns out, this is contributing to issue #52592 - gen 0 budget shoots upruptly to 5.1 GB and drops back.