-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Optimize DateTimeOffset #58169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize DateTimeOffset #58169
Conversation
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
|
Thanks.
Can you share performance numbers? What are the wins and where are they coming from?
Can you remove the style-only changes? It's not clear to me what's here for optimization reasons and what's just style. |
src/libraries/System.Private.CoreLib/src/System/Buffers/Text/Utf8Constants.cs
Show resolved
Hide resolved
src/libraries/System.Private.CoreLib/src/System/Globalization/DateTimeFormatInfo.cs
Show resolved
Hide resolved
|
Tagging subscribers to this area: @dotnet/area-system-runtime Issue Details
|
e04a27a to
652d545
Compare
652d545 to
745b2d4
Compare
@pentp For the performance numbers, we'll want to see output from BenchmarkDotNet for the affected microbenchmarks, comparing the results with and without these changes. If needed, you can refer to dotnet/performance for more info. Thanks! |
|
@pentp are you still working on this? No particular rush, just wanted to ensure that was the case since many people took a break over the holidays. There are still several pending comments above that would need to be resolved. |
|
This pull request has been automatically marked |
|
@tannergooding I took a longer break from non-work coding. Will start getting back on track with my open PRs this weekend probably. |
|
This pull request has been automatically marked |
|
This pull request will now be closed since it had been marked |
DateTimeOffsetDateTimeDateTime[Offset]DateTimeOffset.UtcNowto not have Kind=Utc in its_dateTimevalue (the existing assert didn't catch it because it was basically a no-op). Added better asserts.