Skip to content

Conversation

@pentp
Copy link
Contributor

@pentp pentp commented Aug 26, 2021

  • Optimize and cleanup DateTimeOffset
  • Some additional optimizations for DateTime
  • Cleanup some uses of DateTime[Offset]
  • Fix DateTimeOffset.UtcNow to not have Kind=Utc in its _dateTime value (the existing assert didn't catch it because it was basically a no-op). Added better asserts.

@ghost
Copy link

ghost commented Aug 26, 2021

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Aug 26, 2021
@stephentoub
Copy link
Member

Thanks.

Optimize DateTimeOffset

Can you share performance numbers? What are the wins and where are they coming from?

Cleanup

Can you remove the style-only changes? It's not clear to me what's here for optimization reasons and what's just style.

@ghost
Copy link

ghost commented Sep 20, 2021

Tagging subscribers to this area: @dotnet/area-system-runtime
See info in area-owners.md if you want to be subscribed.

Issue Details
  • Optimize and cleanup DateTimeOffset
  • Some additional optimizations for DateTime
  • Cleanup some uses of DateTime[Offset]
  • Fix DateTimeOffset.UtcNow to not have Kind=Utc in its _dateTime value (the existing assert didn't catch it because it was basically a no-op). Added better asserts.
Author: pentp
Assignees: -
Labels:

area-System.Runtime, community-contribution

Milestone: -

@pentp pentp force-pushed the datetimeoffset-lean branch from e04a27a to 652d545 Compare October 5, 2021 20:26
@jeffhandley
Copy link
Member

Can you share performance numbers? What are the wins and where are they coming from?

@pentp For the performance numbers, we'll want to see output from BenchmarkDotNet for the affected microbenchmarks, comparing the results with and without these changes. If needed, you can refer to dotnet/performance for more info.

Thanks!

@tannergooding
Copy link
Member

@pentp are you still working on this?

No particular rush, just wanted to ensure that was the case since many people took a break over the holidays. There are still several pending comments above that would need to be resolved.

@tannergooding tannergooding added needs-author-action An issue or pull request that requires more info or actions from the author. and removed needs more info labels Jan 7, 2022
@ghost ghost added the no-recent-activity label Jan 21, 2022
@ghost
Copy link

ghost commented Jan 21, 2022

This pull request has been automatically marked no recent activity because it has not had any activity for 14 days. It will be closed if no further activity occurs within 14 more days. Any new comment (by anyone, not necessarily the author) will remove no recent activity.

@pentp
Copy link
Contributor Author

pentp commented Feb 3, 2022

@tannergooding I took a longer break from non-work coding. Will start getting back on track with my open PRs this weekend probably.

@ghost ghost removed no-recent-activity needs-author-action An issue or pull request that requires more info or actions from the author. labels Feb 3, 2022
@tannergooding tannergooding added the needs-author-action An issue or pull request that requires more info or actions from the author. label Mar 23, 2022
@ghost ghost added the no-recent-activity label Apr 6, 2022
@ghost
Copy link

ghost commented Apr 6, 2022

This pull request has been automatically marked no-recent-activity because it has not had any activity for 14 days. It will be closed if no further activity occurs within 14 more days. Any new comment (by anyone, not necessarily the author) will remove no-recent-activity.

@ghost
Copy link

ghost commented Apr 21, 2022

This pull request will now be closed since it had been marked no-recent-activity but received no further activity in the past 14 days. It is still possible to reopen or comment on the pull request, but please note that it will be locked if it remains inactive for another 30 days.

@ghost ghost closed this Apr 21, 2022
@ghost ghost locked as resolved and limited conversation to collaborators May 21, 2022
@pentp pentp deleted the datetimeoffset-lean branch January 4, 2025 02:26
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-System.DateTime community-contribution Indicates that the PR has been added by a community member needs-author-action An issue or pull request that requires more info or actions from the author. no-recent-activity

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants