Handle shadowed property names in DiagnosticsSourceEventSource #58145
Conversation
|
Tagging subscribers to this area: @tommcdon, @krwq Issue DetailsFixes #57709 If a class, such as This patch adds a fast path for most use cases that will only check the declared properties on the given type and won't fall back to the looping logic unless it needs to. This should be ported to 6.0-rc2 if approved.
|
|
|
|
/backport to release/6.0 |
|
Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/1171946310 |
ghost
locked as resolved and limited conversation to collaborators
4 participants
Fixes #57709
If a class, such as
SqlLiteCommand, has a shadowed property name, such asSqlLiteCommand.ConnectionandDbCommand.Connection, the logic inDiagnosticSourceEventSourcewill throw an ambiguous match exception when trying to resolve a property with that name.This patch adds a fast path for most use cases that will only check the declared properties on the given type and won't fall back to the looping logic unless it needs to.
This should be ported to 6.0-rc2 if approved.