Clean-up duplicated PathInternal files #57988
Conversation
|
Tagging subscribers to this area: @dotnet/area-system-io Issue DetailsThere were files named This PR removes duplicity by deleting/moving the files in Common to the other folder.
|
There was a problem hiding this comment.
Would "$(CommonPath)System\IO\PathInternal.* be more appropriate place for these files?
These files do not contain public APIs. I think we only use CoreLib includes for files with public APIs, and only include them for legacy TFM configurations.
carlossanlop
left a comment
carlossanlop
left a comment
There was a problem hiding this comment.
LGTM. I think Jan's suggestion makes sense to move the file to the other location.
|
We also wanted to merge the |
Yes, separate; but I think that's a broader issue that not just affects System.IO space. |
ghost
locked as resolved and limited conversation to collaborators
3 participants
There were files named
PathInternal*.csunder thelibraries/Common/src/System/IO folder, while at the same time we havePathInternal*.csfiles underlibraries/System.Private.CoreLib/src/System/IO, the content in both files was more or less identical.This PR removes duplicity by deleting/moving the files in Common to the other folder.