Fix regression in dictionary key serialization when registering custom primitive converters. #57138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tom primitive converters.
|
Tagging subscribers to this area: @eiriktsarpalis, @layomia Issue DetailsReverts a breaking change intentionally introduced in #50074: when users register a custom converter for a primitive type in the reflection-based serializer, the key serialization logic for that type will fall back to the default converter, assuming it has been rooted by the current application. Fixes #53241.
|
layomia
approved these changes
Aug 10, 2021
...ries/System.Text.Json/src/System/Text/Json/Serialization/JsonSerializerOptions.Converters.cs
Show resolved
Hide resolved
.../src/System/Text/Json/Serialization/Converters/Collection/DictionaryOfTKeyTValueConverter.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Text.Json/src/System/Text/Json/Serialization/JsonConverterOfT.cs
Outdated
Show resolved
Hide resolved
...ries/System.Text.Json/src/System/Text/Json/Serialization/JsonSerializerOptions.Converters.cs
Show resolved
Hide resolved
|
Hello @eiriktsarpalis! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit 
ghost
locked as resolved and limited conversation to collaborators
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts a breaking change intentionally introduced in #50074: when users register a custom converter for a primitive type in the reflection-based serializer, the key serialization logic for that type will fall back to the default converter, assuming it has been rooted by the current application.
Fixes #53241.