[MonoAOTCompiler] accept more than one AotProfilePath #57111
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes part of: dotnet#56989 The Android workload needs to be able to pass in multiple AOT profiles to the `<MonoAOTCompiler/>` MSBuild task. We plan on shipping a default profile in the Android workload, as well as the MAUI workload. .NET MAUI would have two profiles when using profiled AOT. Adding `profile-only`, and then multiple `profile` arguments is currently working in legacy Xamarin.Android: https://github.com/xamarin/xamarin-android/blob/77895e2a03ed91fdf3729cde54501f91e7d1a36f/src/Xamarin.Android.Build.Tasks/Tasks/GetAotArguments.cs#L256-L260 Either a single property or item group can be passed in for `AotProfilePath` now. I avoided changing the name, as it looks like it might be used by wasm.
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
Member
|
cc @vargaz |
radical
reviewed
Aug 10, 2021
Co-authored-by: Ankit Jain <[email protected]>
akoeplinger
approved these changes
Aug 11, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes part of: #56989
The Android workload needs to be able to pass in multiple AOT profiles
to the
<MonoAOTCompiler/>MSBuild task. We plan on shipping adefault profile in the Android workload, as well as the MAUI workload.
.NET MAUI would have two profiles when using profiled AOT.
Adding
profile-only, and then multipleprofilearguments iscurrently working in legacy Xamarin.Android:
https://github.com/xamarin/xamarin-android/blob/77895e2a03ed91fdf3729cde54501f91e7d1a36f/src/Xamarin.Android.Build.Tasks/Tasks/GetAotArguments.cs#L256-L260
Either a single property or item group can be passed in for
AotProfilePathnow. I avoided changing the name, as it looks like itmight be used by wasm.