Set the cmake policy for CMP0066 and CMP0067 #56811
Conversation
ghost
added
the
|
Tagging subscribers to this area: @hoyosjs Issue DetailsAs per https://cmake.org/cmake/help/v3.21/policy/CMP0066.html and https://cmake.org/cmake/help/v3.21/policy/CMP0067.html, the default policy for these is The net effect of this is that certain header or other checks may be misreported between the test and what we ultimately compile our source with and may cause less efficient code or other downstream failures such as #56746. This resolves #56746 by ensuring that these policies are explicitly set to
|
|
@jkoritzinsky, any other sign-off needed here or can we merge? |
|
I think we can merge this |
2 participants
As per https://cmake.org/cmake/help/v3.21/policy/CMP0066.html and https://cmake.org/cmake/help/v3.21/policy/CMP0067.html, the default policy for these is
OLDmeaning thattry_compilechecks (such as is done forcheck_c_source_compiles) will not respectCMAKE_<LANG>_FLAGS,CMAKE_<LANG>_STANDARD,CMAKE_<LANG>_STANDARD_REQUIRED, andCMAKE_<LANG>_EXTENSIONSvariables.The net effect of this is that certain header or other checks may be misreported between the test and what we ultimately compile our source with and may cause less efficient code or other downstream failures such as #56746.
This resolves #56746 by ensuring that these policies are explicitly set to
NEWso that the cmake tests match our source compilation configuration and are accurate.