Cleaned up version of earlier PR #48601. #56772
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/gc Issue DetailsPort of ConserveMemory setting we implemented on .NET Framework.
|
Maoni0
reviewed
Aug 4, 2021
src/coreclr/gc/gc.cpp
Outdated
| } | ||
| } | ||
|
|
||
| if ((conserve_mem_setting != 0) && (n >= max_generation)) |
Member
There was a problem hiding this comment.
n cannot be > max_generation... it can only be at most max_generation.
Contributor
Author
There was a problem hiding this comment.
I know - I changed the >= to ==.
Maoni0
reviewed
Aug 4, 2021
src/coreclr/gc/gc.cpp
Outdated
| for (int hn = 0; hn < gc_heap::n_heaps; hn++) | ||
| { | ||
| gc_heap* hp = gc_heap::g_heaps[hn]; | ||
| size += hp->generation_sizes (hp->generation_of (gen_number)); |
Member
There was a problem hiding this comment.
this should use generation_size, not generation_sizes
Contributor
Author
There was a problem hiding this comment.
Yup, thanks for catching!
Remove changes for the heap_hard_limit case - we'll do those later. Fixed another place where I had called generation_sizes instead of generation_size.
Contributor
Author
|
/backport to release/6.0 |
Contributor
|
Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/1193690302 |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port of ConserveMemory setting we implemented on .NET Framework.