[wasm] Build Wasm.Build.Tests only on the WBT job, on CI#56769
[wasm] Build Wasm.Build.Tests only on the WBT job, on CI#56769radical merged 4 commits intodotnet:mainfrom
Conversation
ghost
added
the
|
Tagging subscribers to this area: @directhex Issue Details
|
|
Tagging subscribers to 'arch-wasm': @lewing Issue Details
|
lewing
left a comment
lewing
left a comment
There was a problem hiding this comment.
It couldn't you set TestAssemblies=false and avoid the wasm specific condition in the libraries setup?
It is used in other cases, like the linker tests (see https://github.com/dotnet/runtime/blob/main/eng/pipelines/libraries/execute-trimming-tests-steps.yml#L7, and https://github.com/dotnet/runtime/blob/main/eng/pipelines/runtime-linker-tests.yml#L79). The intention is clearer with having an explicit property. |
Co-authored-by: Larry Ewing <[email protected]>
|
|
|
I'd kind of prefer TestWasmBuild=true and dropping the only idea but it isn't a strong preference |
With the |
2 participants
On the
_WasmBuildTestsjob, we build the library tests also, which aren't used at all. So, disable that. And we don't need to build Wasm.Build.Tests for the regular build job, so disable there.This saves 10-12 mins of build time.