Enable ICU trimming for Invariant=true and PredefinedCulturesOnly unspecified #56667
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @tarekgh, @safern Issue Details@RalfKornmannEnvision have noticed that ICU initialization is not getting trimmed when Invariant=true and PredefinedCulturesOnly unspecified (https://gitter.im/dotnet/corert?at=610514ee36b0b97fa2d99aff). The problem is that the Setting class constructor that initializes ICU gets referenced by the PredefinedCulturesOnly property. Moving the PredefinedCulturesOnly out of the Setting class fixes the problem.
|
stephentoub
reviewed
Jul 31, 2021
src/libraries/System.Private.CoreLib/src/System/Globalization/GlobalizationMode.cs
Outdated
Show resolved
Hide resolved
stephentoub
approved these changes
Jul 31, 2021
safern
approved these changes
Jul 31, 2021
tarekgh
approved these changes
Jul 31, 2021
Member
tarekgh
reviewed
Jul 31, 2021
src/libraries/System.Private.CoreLib/src/System/Globalization/GlobalizationMode.cs
Show resolved
Hide resolved
tarekgh
approved these changes
Jul 31, 2021
eerhardt
reviewed
Aug 2, 2021
| static Settings() | ||
| { | ||
| if (!Invariant) | ||
| // Use GlobalizationMode.Invariant to allow ICU initialization to be trimmed when Invariant=false |
Member
There was a problem hiding this comment.
when Invariant=false => when Invariant=true
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@RalfKornmannEnvision noticed that ICU initialization is not getting trimmed when Invariant=true and PredefinedCulturesOnly is unspecified (https://gitter.im/dotnet/corert?at=610514ee36b0b97fa2d99aff). The problem is that the Setting class constructor that initializes ICU gets referenced by the PredefinedCulturesOnly property in this case. Moving the PredefinedCulturesOnly out of the Setting class fixes the problem.