-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Added Visual Studio build tools (#55629) #56234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Added description of build tools (CMake, Ninja and Python) installation as Visual Studio Individual Components. Added emphasis (bold) of Visual Studio installer sections and components (replaces previously used different styles of quotes).
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
hoyosjs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
|
please ignore the gc-standalone pipeline (it got accidently enabled for PRs, I have disabled it now). Thx. |
Python 64-bit component is enough for building x86 and x64 target architectures.
jkotas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
Added description of build tools (CMake, Ninja and Python) installation as Visual Studio Individual Components.
Added emphasis (bold) of Visual Studio installer sections and components (replaces previously used different styles of quotes).
Please feel free to suggest any corrections or request any changes...¨
Edit: All three tools are discoverable by the build environment checking mechanism, and were also manually verified via
wherecommand in the build terminal. The Python VS component installs Python Launcher that places py.exe into the system root directory (automatically included in the global PATH variable).