[interp] Add IL seq points #56137
Merged
[interp] Add IL seq points #56137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @BrzVlad Issue DetailsFixes #51096
|
Member
Author
|
@thaystg @vargaz It seems we have some duplicated IL offset computation mechanisms in the runtime. During codegen we store iloffset/nativeoffset pairs in a line_number array which then gets saved in the debug info for a method. We also have the IL seq points that serve the same purpose, being saved in the |
vargaz
approved these changes
Jul 22, 2021
Interpreter was generating only sdb seq points for implementing debugger support. Add also il seq points which are used for stack traces when debugging information is not present. We add IL seq points in locations where IL stack is empty, same as JIT.
It skips over NOPs
BrzVlad
force-pushed
the
fix-interp-seq-points
branch
from
69e89e0 to
531b2e8
Compare
lambdageek
reviewed
Jul 27, 2021
We were disabling some of them all over the place. They shouldn'd be running on mono.
BrzVlad
force-pushed
the
fix-interp-seq-points
branch
from
64ba0d8 to
6f01218
Compare
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #51096