Revert Version.TryFormat changes #56051
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was already optimized to use spans directly. Using our new span-based interpolated string handler was simpler code, but a few more nanoseconds. Reverting.
Make error handling a bit more clear, and use uint formatting rather than int formatting for small perf boost.
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
|
Tagging subscribers to this area: @dotnet/area-system-runtime Issue DetailsFixes #56011 I'd updated the implementation to use the new span-based interpolated string handler. The code was simpler/cleaner, but the code was already fairly-tuned direct span-based code, and while the extra overhead was a few nanoseconds, that was a measurable percentage of the overall time. So, I'm reverting it so as not to regress. And while here, I made a few tweaks that give it a small extra boost.
|
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #56011
I'd updated the implementation to use the new span-based interpolated string handler. The code was simpler/cleaner, but the code was already fairly-tuned direct span-based code, and while the extra overhead was a few nanoseconds, that was a measurable percentage of the overall time. So, I'm reverting it so as not to regress. And while here, I made a few tweaks that give it a small extra boost.