[Mono] Fix inconsistent linkage error in dynamic component build on Windows. #55142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet#54887 added MONO_COMPONENT_API to mono_gc_memmove_atomic.h, but that function is declared in two different headers, memfuncs.h and gc-internal-agnostic.h and the second one didn't use MONO_COMPONENT_API causing inconsistent linking errors on Windows when building dynamic components.
|
Tagging subscribers to this area: Issue Details#54887 added
|
lambdageek
approved these changes
Jul 6, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#54887 added
MONO_COMPONENT_APIto mono_gc_memmove_atomic.h, but that function is declared in two different headers, memfuncs.h and gc-internal-agnostic.h and the second one didn't useMONO_COMPONENT_APIcausing inconsistent linking errors on Windows when building dynamic components.