[release/6.0-preview6] Revert "Fix 54025" #54729
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit b2fe667.
ghost
added
the
|
Tagging subscribers to this area: @tommcdon |
Member
|
/azp run dotnet-linker-tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jeffschwMSFT
approved these changes
Jun 25, 2021
Member
jeffschwMSFT
left a comment
jeffschwMSFT
left a comment
There was a problem hiding this comment.
Approved. We should consider this for Preview 6
Member
|
/azp run runtime-dev-innerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
|
@hoyosjs can you double check the failures in CI and then we can merge. |
Member
|
I've retriggered the leg. The issue is a known in bug in XUnit that's starting to cause us more pronounced pain. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #54728 to release/6.0-preview6
/cc @hoyosjs
Customer Impact
Reverting as this change breaks several important scenarios in debugging in Linux and macOS.
Testing
Back to heavily tested version - nothing depends on this change other than the bug it tried to fix.
Risk
Very low.