Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Test Http2_MultipleConnectionsEnabled_ConnectionLimitNotReached_ConcurrentRequestsSuccessfullyHandled successfully completed 60000 iterations on Ubuntu 20.04 under WSL2 on a local machine.

did you run whole set or just the single test @alnikola ?

I ran only this test but through [MemberData].

These will likely be affected by my connection pooling changes.

If you want, I can just re-enable them in my PR (if they look clean on my machine).

@geoffkizer I'd enable them in a separate PR to make issues backtracking easier. But if you'd like it more, then go ahead and enable it in your PR.

anything flaky needs to be run as whole bundle @alnikola. Many tests would always pass when executed in isolation but may fail when completing for resources with other test.

@alnikola Makes sense, go ahead and enable them.

@wfurt Are talking about running only the test class owning this test (i.e. SocketsHttpHandlerTest_Http2) or all of tests in System.Net.Http.FunctionalTests project in a loop?

What about Http2_MultipleConnectionsEnabled_IdleConnectionTimeoutExpired_ConnectionRemovedAndNewCreated also?

Test Http2_MultipleConnectionsEnabled_InfiniteRequestsCompletelyBlockOneConnection_RemaningRequestsAreHandledByNewConnection also successfully completed 60000 iterations on Ubuntu 20.04 under WSL2 on a local machine.

What about Http2_MultipleConnectionsEnabled_IdleConnectionTimeoutExpired_ConnectionRemovedAndNewCreated also?

This test is failing locally. I'm investigating it.

I would run the whole System.Net.Http.FunctionalTests as CI would - just locally so it is more under controlled environment.

I would run the whole System.Net.Http.FunctionalTests as CI would - just locally so it is more under controlled environment.

OK, it makes sense. I will try it.

I would run the whole System.Net.Http.FunctionalTests as CI would - just locally so it is more under controlled environment.

I ran the whole System.Net.Http.FunctionalTests test set locally for ~30 mins and everything completed successfully.

/azp run runtime-libraries-coreclr

/azp run runtime-libraries-coreclr innerloop

Unfortunately, Http2_MultipleConnectionsEnabled_ConnectionLimitNotReached_ConcurrentRequestsSuccessfullyHandled now failed in CI on Windows, thus we cannot enable it right now.

System.Net.Http.Functional.Tests.SocketsHttpHandlerTest_Http2.Http2_MultipleConnectionsEnabled_ConnectionLimitNotReached_ConcurrentRequestsSuccessfullyHandled(a: 10) [FAIL]
      System.Threading.Tasks.TaskCanceledException : The request was canceled due to the configured HttpClient.Timeout of 100 seconds elapsing.
      ---- System.TimeoutException : The operation was canceled.
      -------- System.Threading.Tasks.TaskCanceledException : The operation was canceled.
      Stack Trace:
        /_/src/libraries/System.Net.Http/src/System/Net/Http/HttpClient.cs(618,0): at System.Net.Http.HttpClient.HandleFailure(Exception e, Boolean telemetryStarted, HttpResponseMessage response, CancellationTokenSource cts, CancellationToken cancellationToken, CancellationTokenSource pendingRequestsCts)
        /_/src/libraries/System.Net.Http/src/System/Net/Http/HttpClient.cs(541,0): at System.Net.Http.HttpClient.<SendAsync>g__Core|83_0(HttpRequestMessage request, HttpCompletionOption completionOption, CancellationTokenSource cts, Boolean disposeCts, CancellationTokenSource pendingRequestsCts, CancellationToken originalCancellationToken)
        /_/src/libraries/System.Net.Http/tests/FunctionalTests/SocketsHttpHandlerTest.cs(2287,0): at System.Net.Http.Functional.Tests.SocketsHttpHandlerTest_Http2.PrepareConnection(Http2LoopbackServer server, HttpClient client, UInt32 maxConcurrentStreams, Int32 readTimeout, Int32 expectedWarmUpTasks)
        /_/src/libraries/System.Net.Http/tests/FunctionalTests/SocketsHttpHandlerTest.cs(2070,0): at System.Net.Http.Functional.Tests.SocketsHttpHandlerTest_Http2.Http2_MultipleConnectionsEnabled_ConnectionLimitNotReached_ConcurrentRequestsSuccessfullyHandled(Int32 a)
        --- End of stack trace from previous location --

However, it seems that the test job itself timed out and was terminated, so it might be it wasn't an actual test failure.

I will enable only Http2_MultipleConnectionsEnabled_InfiniteRequestsCompletelyBlockOneConnection_RemaningRequestsAreHandledByNewConnection because others are failing.