Keep obj node for struct ArrayIndex. #54584
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandreenko
added
the
area-CodeGen-coreclr
Contributor
Author
|
PTAL @BruceForstall this is the last preparation for copyBlock butchery, cc @dotnet/jit-contrib |
BruceForstall
approved these changes
Jun 23, 2021
thaystg
added a commit
to thaystg/runtime
that referenced
this pull request
Jun 23, 2021
…nitial_config * origin/main: (362 commits) [wasm][debugger] Reuse debugger-agent on wasm debugger (dotnet#52300) Put Crossgen2 in sync with dotnet#54235 (dotnet#54438) Move System.Object serialization to ObjectConverter (dotnet#54436) Move setting fHasVirtualStaticMethods out of sanity check section (dotnet#54574) [wasm] Compile .bc->.o in parallel, before passing to the linker (dotnet#54053) Change PathInternal.IsCaseSensitive to a constant (dotnet#54340) Make mono_polling_required a public symbol (dotnet#54592) Respect EventSource::IsSupported setting in more codepaths (dotnet#51977) Root ComActivator for hosting (dotnet#54524) Add ILLink annotations to S.D.Common related to DbConnectionStringBuilder (dotnet#54280) Fix finalizer issue with regions (dotnet#54550) Add support for multi-arch install locations (dotnet#53763) Update library testing docs page to reduce confusion (dotnet#54324) [FileStream] handle UNC and device paths (dotnet#54483) Update NetAnalyzers version (dotnet#54511) Added runtime dependency to fix the intermittent test failures (dotnet#54587) Disable failing System.Reflection.Tests.ModuleTests.GetMethods (dotnet#54564) [wasm] Move AOT builds from `runtime-staging` to `runtime` (dotnet#54577) Keep obj node for ArrayIndex. (dotnet#54584) Disable another failing MemoryCache test (dotnet#54578) ...
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That was the last IND node on the LHS of a struct assignment without structHandle/known size.
There are small regressions because we now create
NULLCHECKnodes where before we were keepingADDR(INDthat rationalizer was destroying.Edited: The diffs are small and they are minopts only (don't create INDEX_ADDR in other cases, thanks @erozenfeld). The issue is similar to #44087 but because it minopts we won't delete the extra node even when the issue is fixed.
***** BB05 STMT00003 (IL 0x00E... ???) [000016] ---XG+------ * COMMA void - [000013] ---XG+------ +--* ADDR byref - [000012] a--XG+-N---- | \--* IND struct + [000014] ---XG+------ +--* NULLCHECK int [000029] ---XG+------ | \--* INDEX_ADDR byref [000010] -----+------ | +--* LCL_VAR ref V03 tmp1 [000011] -----+------ | \--* CNS_INT int 1 [000015] -----+------ \--* NOP void lea rax, bword ptr [rax+8*rcx+16] +cmp dword ptr [rax], eax mov rax, gword ptr [V01 rbp-08H]