-
Notifications
You must be signed in to change notification settings - Fork 5.3k
removing more crossgen code from being built. #54458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Should improve build times further.
|
Tagging subscribers to this area: @hoyosjs Issue DetailsShould improve build times further.
|
|
cc @dotnet/crossgen-contrib . This should remove about ~80 files from compiling. |
|
win-arm64 failures are due to overall helix arm64 flakiness. |
davidwrighton
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but you can probably remove more. In a future PR, I would see if you can remove all the files in src/coreclr/jit/crossgen, as well as the cmakelists.txt in src/coreclr/zap
hoyosjs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should give a heads up to Samsung in crossgen cleanup. I believe they were still using this. Linking #54129
|
Yeah will link to #54129 once merged. |
yeah will remove more cmakelists in subsequent PRs, but dont believe they are being exercised so wouldnt affect build times. |
|
Hey @alpencolt, crossgen has been removed from building in the runtime repo, and we might start removing (the now defunct) code post .net preview7, but could defer till start of .net 7 if that helps. |
Should improve build times further.