Lazy-allocate ValidationState.CurPos #54346
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The array is only used for a subset of validators; no point in paying for this array for every ValidationState instance even if it's not going to be used.
ghost
added
the
|
Tagging subscribers to this area: @buyaa-n, @krwq Issue DetailsThe array is only used for a subset of validators; no point in paying for this array for every ValidationState instance even if it's not going to be used. With the same scenario as in #54344, these drop from 5000 to 11:
|
krwq
approved these changes
Jun 17, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The array is only used for a subset of validators; no point in paying for this array for every ValidationState instance even if it's not going to be used.
With the same scenario as in #54344, these drop from 5000 to 11:
