Fix SuperPMI handling of resolveVirtualMethod #54315
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change dotnet#53567 introduced new functionality to the JIT-EE resolveVirtualMethod() API. This fixes the SuperPMI implementation in the case where the API returns `false`, where some data fields are not initialized. Fixes crossgen2 SuperPMI collections. Fixes dotnet#54310
ghost
added
the
area-CodeGen-coreclr
Contributor
Author
|
@kunalspathak @davidwrighton @dotnet/jit-contrib PTAL |
kunalspathak
approved these changes
Jun 17, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change #53567 introduced new functionality to the JIT-EE
resolveVirtualMethod() API. This fixes the SuperPMI implementation
in the case where the API returns
false, where some data fieldsare not initialized.
Fixes crossgen2 SuperPMI collections.
Fixes #54310