Update superpmi.py script for new 'runtime' repo layout #541
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated a few comments as well.
jashook
reviewed
Dec 5, 2019
| """ Main method | ||
| """ | ||
|
|
||
| # await/async requires python >= 3.5 |
Contributor
There was a problem hiding this comment.
Do you mind changing the comment to >= 3.8
Contributor
Author
There was a problem hiding this comment.
Do you want to force 3.8+? I made the comment say 3.8, but I'm not sure it actually requires anything more than 3.5 (you said it needs that for async)
Contributor
There was a problem hiding this comment.
It technically requires 3.7 as 3.6 on windows has an async bug.
| """ | ||
|
|
||
| # await/async requires python >= 3.5 | ||
| if sys.version_info.major < 3 and sys.version_info.minor < 5: |
Contributor
There was a problem hiding this comment.
Also could you change the check to sys.version_info.minor < 8
jashook
approved these changes
Dec 5, 2019
Contributor
jashook
left a comment
jashook
left a comment
There was a problem hiding this comment.
Other than that lgtm thank you!
Contributor
Author
|
I went ahead and merged. If you want to force 3.8+ instead of 3.5+ as it is now, I'll do that in a separate change. |
Contributor
|
We should force 3.7 |
Closed
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated a few comments as well.