Make some Brotli p/invokes blittable #54029
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/area-system-io-compression Issue DetailsFound that two of the Brotli p/invokes could easily be made blittable (inlinable during JIT) while prototyping a cc @AaronRobinsonMSFT @jkoritzinsky
|
stephentoub
approved these changes
Jun 10, 2021
AaronRobinsonMSFT
approved these changes
Jun 10, 2021
jkoritzinsky
approved these changes
Jun 10, 2021
jkotas
reviewed
Jun 10, 2021
|
|
||
| [DllImport(Libraries.CompressionNative)] | ||
| internal static extern unsafe bool BrotliDecoderDecompress(nuint availableInput, byte* inBytes, ref nuint availableOutput, byte* outBytes); | ||
| internal static extern unsafe int BrotliDecoderDecompress(nuint availableInput, byte* inBytes, nuint* availableOutput, byte* outBytes); |
Member
There was a problem hiding this comment.
Should we make all of PInvokes in this file to return int for consistency?
Also, would it make sense to use BOOL to make it clear that this is returning boolean value?
Member
Author
There was a problem hiding this comment.
Are you talking about that Interop.BOOL enum?
stephentoub
approved these changes
Jun 11, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found that two of the Brotli p/invokes could easily be made blittable (inlinable during JIT) while prototyping a
DllImportsource generator.cc @AaronRobinsonMSFT @jkoritzinsky