[Mono] Multi-target RuntimeConfigParser Task #53827
Conversation
Fixes dotnet#53811 The props were not taking into account the right paths.
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
| <RuntimeConfigParserTasksAssemblyPath Condition="'$(MSBuildRuntimeType)' == 'Core'">$(MSBuildThisFileDirectory)..\tasks\net6.0\RuntimeConfigParser.dll</RuntimeConfigParserTasksAssemblyPath> | ||
| <RuntimeConfigParserTasksAssemblyPath Condition="'$(MSBuildRuntimeType)' != 'Core'">$(MSBuildThisFileDirectory)..\tasks\net472\RuntimeConfigParser.dll</RuntimeConfigParserTasksAssemblyPath> |
There was a problem hiding this comment.
Not sure if it's available here but this should use $(NetCoreAppToolCurrent) and $(TargetFrameworkForNETFramework) since this is how we're building the RuntimeConfigParser.csproj
Although I wonder if we should change that to hardcode a specific version since NetCoreAppToolCurrent was more designed for tasks used inside of the dotnet/runtime repo and we're shipping more tasks outside of it now:
There was a problem hiding this comment.
Actually, scratch that. The Sdk.props is imported on the user's machine so we won't have $(NetCoreAppToolCurrent).
There was a problem hiding this comment.
The gist of my comment still remains though: we need to make sure we either update this place here whenever we bump the NetCoreAppToolCurrent or stop using NetCoreAppToolCurrent in the tasks csproj
|
Thanks for making this change! |
ghost
locked as resolved and limited conversation to collaborators
4 participants
Fixes #53811
The props were not taking into account the right paths.