Remove some unnecessary string copies in hosting layer #53631
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov Issue DetailsCut out a bunch of unnecessary string copies:
On Windows, this was about ~3k allocations for launching a console app.
|
AaronRobinsonMSFT
approved these changes
Jun 2, 2021
vitek-karas
approved these changes
Jun 2, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cut out a bunch of unnecessary string copies:
pal::char_t*for some static string literalspal::char_t*forpal::to_lower(that's actually what the callers had - we were just forcing them all to create an extra string for no reason)On Windows, this was about ~3k fewer allocations for launching a console app.
Tried some really rough printf timing on Windows - not sure the best way to do this - I just used
std::chrono::system_clockto add print lines and averaged over 30 launches. So all grains of salt with these numbers, but it seemed a bit improved on my machine:corehost_maintocoreclr_t::createbefore loading coreclr (us)hostfxr_main_startupinfotocoreclr_t::createbefore loading coreclr (us)