JIT: don't allow negative edge weights #52884
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the sovler wants to set the edge weight below zero, set it to zero if within slop, or disallow if not. Addresses assert seen in dotnet#52864.
ghost
added
the
area-CodeGen-coreclr
Member
Author
|
cc @dotnet/jit-contrib @trylek I will add more assertion/post-phase checking for edge weights in a follow-up PR. |
BruceForstall
approved these changes
May 18, 2021
Member
Author
Member
Member
Author
Indeed. Thanks. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the solver wants to set the edge weight below zero, set it to
zero if within slop, or disallow if not.
Addresses assert seen in
#52864#52785.