Make RandomNumberGenerator.Create return a singleton #52495
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @bartonjs, @vcsjones, @krwq, @GrabYourPitchforks Issue DetailsInspired by #40169 and #52373. This makes the implementation of Attempting to dispose of the returned singleton instance will no-op. The implementation of /cc @jeffhandley
|
vcsjones
reviewed
May 8, 2021
...tography.Algorithms/src/Internal/Cryptography/RandomNumberGeneratorImplementation.Windows.cs
Outdated
Show resolved
Hide resolved
bartonjs
approved these changes
May 11, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by #40169 and #52373. This makes the implementation of
RandomNumberGenerator.Create()return a singleton instance. So apps which need to callRandomNumberGenerator.Create()instead of using the static accelerator APIs can still take advantage of a non-allocating factory.Attempting to dispose of the returned singleton instance will no-op. The implementation of
RandomNumberGenerator.Create(string)is not changed. Using that API will continue to go through the normalCryptoConfigactivation code paths./cc @jeffhandley