-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Reduce UriBuilder allocations #51826
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/ncl Issue Details
Should be functionally equivalent. private const string Scheme = "https", Host = "example.com", Path = "/random/path?someQuery=value", Extra = "?someQuery=value&foo=bar#some-fragment";
private const int Port = 443;
private static readonly Uri _uri = new($"{Scheme}://{Host}{Path}{Extra}");
private static readonly UriBuilder _builder = new(_uri);
[Benchmark]
public Uri Passthrough() => new UriBuilder(_uri).Uri;
[Benchmark] // What we do in HttpConnectionPool ctor
public string HttpAuthority() => new UriBuilder(Uri.UriSchemeHttp, Host, Port).Uri.IdnHost;
[Benchmark]
public Uri FullCtor() => new UriBuilder(Scheme, Host, Port, Path, Extra).Uri;
[Benchmark]
public string BuilderToString() => _builder.ToString();
There are other tricks we can add to reduce allocations:
|
xtqqczze
reviewed
Apr 26, 2021
ManickaP
approved these changes
May 11, 2021
Member
ManickaP
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
MihaZupan
commented
May 11, 2021
Member
Author
|
/azp run runtime |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_schemeDelimiterfieldSetFieldsFromUriandInitdoing exactly the same thing, butInitalso callsSetFieldsFromUri. RemovedInitto avoid doing the same work twice.string extraValue, avoid stripping?and#only to add them right back in property setters (avoids unnecessary substring+concat allocations)ToStringwithValueStringBuilderShould be functionally equivalent.
There are other tricks we can add to reduce allocations:
ToStringlike fetchingPathAndQueryinstead ofPath,Query