Skip to content

Conversation

@GrabYourPitchforks
Copy link
Member

This is just the internal Array.NativeLength property aspect of #51548, refactored out into its own PR. There's no padding cleverness in this PR. It avoids the explicit cast on the consumer side and short-circuits the unnecessary int -> long -> int conversion on 32-bit platforms.

Will wait for #51351 to go in first, then rebase this PR atop that one.

@ghost
Copy link

ghost commented Apr 20, 2021

Tagging subscribers to this area: @tannergooding
See info in area-owners.md if you want to be subscribed.

Issue Details

This is just the internal Array.NativeLength property aspect of #51548, refactored out into its own PR. There's no padding cleverness in this PR. It avoids the explicit cast on the consumer side and short-circuits the unnecessary int -> long -> int conversion on 32-bit platforms.

Will wait for #51351 to go in first, then rebase this PR atop that one.

Author: GrabYourPitchforks
Assignees: -
Labels:

area-System.Runtime

Milestone: 6.0.0

Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@GrabYourPitchforks
Copy link
Member Author

Failing test is known issue #51588.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants