WebRequest/ServicePoint/WebClient Obsoletion Follow-Up #51550
Conversation
ghost
added
|
Note regarding the This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change. |
|
Tagging subscribers to this area: @dotnet/ncl Issue DetailsFixes #41759 During a PR review of #41526, which would have ported #41400 into the release/5.0 branch, there was some PR feedback. Because that port PR was closed without merging, that feedback went unaddressed.
|
| | __`SYSLIB0011`__ | `BinaryFormatter` serialization is obsolete and should not be used. See https://aka.ms/binaryformatter for recommended alternatives. | | ||
| | __`SYSLIB0012`__ | Assembly.CodeBase and Assembly.EscapedCodeBase are only included for .NET Framework compatibility. Use Assembly.Location instead. | | ||
| | __`SYSLIB0013`__ | Uri.EscapeUriString can corrupt the Uri string in some cases. Consider using Uri.EscapeDataString for query string components instead. | | ||
| | __`SYSLIB0014`__ | WebRequest, HttpWebRequest, ServicePoint, and WebClient are obsolete. Use HttpClient instead. | |
There was a problem hiding this comment.
I was wondering previously why this was missing :)
| private int _aborted; | ||
|
|
||
| #pragma warning disable SYSLIB0014 | ||
| #pragma warning disable SYSLIB0014 // WebRequest, HttpWebRequest, ServicePoint, and WebClient are obsolete. Use HttpClient instead. |
There was a problem hiding this comment.
Should we just suppress SYSLIB0014 in System.Net.Requests at the project level? This assembly is entirely about providing these types. Same for System.Net.ServicePoint.
There was a problem hiding this comment.
I'm good with that; will do.
|
The failing test is #51588 |
4 participants
Fixes #41759
During a PR review of #41526, which would have ported #41400 into the release/5.0 branch, there was some PR feedback. Because that port PR was closed without merging, that feedback went unaddressed.
SYSLIBobsoletions