Add metadata update handler to System.ComponentModel.TypeConverter #51466
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @safern Issue DetailsThis is in support of hot reload, to be able to clear TypeConverter's reflection caches in response to types being patched. I'm not familiar with all the inner workings of TypeConverters, but this appears to be what's necessary to clear the reflection caches TypeConverter maintains; please let me know if I've missed something, or if this is problematic in other ways. cc: @tommcdon, @pranavkm, @mikem8361
|
safern
reviewed
Apr 19, 2021
src/libraries/System.ComponentModel.TypeConverter/tests/ReflectionCachesUpdateHandlerTests.cs
Show resolved
Hide resolved
safern
approved these changes
Apr 19, 2021
Member
safern
left a comment
safern
left a comment
There was a problem hiding this comment.
Makes sense from what I understand how hot reload works.
danmoseley
reviewed
Apr 20, 2021
...tem.ComponentModel.TypeConverter/src/System/ComponentModel/ReflectTypeDescriptionProvider.cs
Outdated
Show resolved
Hide resolved
stephentoub
commented
Apr 20, 2021
...tem.ComponentModel.TypeConverter/src/System/ComponentModel/ReflectTypeDescriptionProvider.cs
Outdated
Show resolved
Hide resolved
…omponentModel/ReflectTypeDescriptionProvider.cs
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in support of hot reload, to be able to clear TypeConverter's reflection caches in response to types being patched. I'm not familiar with all the inner workings of TypeConverters, but this appears to be what's necessary to clear the reflection caches TypeConverter maintains; please let me know if I've missed something, or if this is problematic in other ways.
cc: @tommcdon, @pranavkm, @mikem8361