Skip forwarding entrypoint library name to Android application Main()#51397
Merged
marek-safar merged 1 commit intodotnet:mainfrom Apr 16, 2021
Merged
Conversation
|
Tagging subscribers to this area: @directhex Issue DetailsSome of the Android runtime tests were recently broken because they got an "entryPointLibName=" argument in their Main args. After 1a98ba0 we were passing the
|
fanyang-mono
approved these changes
Apr 16, 2021
Member
fanyang-mono
left a comment
fanyang-mono
left a comment
There was a problem hiding this comment.
LGTM! Thanks for fixing this.
Some of the Android runtime tests were recently broken because they got an "entryPointLibName=<test assembly name>" argument in their Main args. This argument is normally used to run a specific test: https://github.com/dotnet/runtime/blob/dd63ea2e6a9cc6f2661b817d15e558fc6605fa17/src/tests/JIT/HardwareIntrinsics/Arm/Shared/Program.cs#L24 After dotnet@1a98ba0 we were passing the `entryPointLibName` down to the managed app args even though it's only supposed to be used to tell the runtime which assembly to run.
akoeplinger
force-pushed
the
skip-entrypoint-forwarding
branch
from
b9d04f1 to
3d3c334
Compare
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some of the Android runtime tests were recently broken because they got an "entryPointLibName=" argument in their Main args.
This argument is normally used to run a specific test:
runtime/src/tests/JIT/HardwareIntrinsics/Arm/Shared/Program.cs
Line 24 in dd63ea2
After 1a98ba0 we were passing the
entryPointLibNamedown to the managed app args even though it's only supposed to be used to tell the runtime which assembly to run.