ensure that sync Connect calls ShouldRetrySyncOperation #50788
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
Tagging subscribers to this area: @dotnet/ncl Issue DetailsI believe this is the root of the issue in #50380. Other sync socket calls (send, recv, etc) call ShouldRetrySyncOperation in order to distinguish between a timeout on a sync socket vs EAGAIN on a socket that's been forced into nonblocking mode. The Connect operation isn't, which means that we are misinterpreting some timeouts as meaning that the socket is now nonblocking. Fixes #50380
|
Contributor
Author
|
/azp run runtime-libraries-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
tmds
reviewed
Apr 6, 2021
src/libraries/System.Net.Sockets/src/System/Net/Sockets/SocketAsyncContext.Unix.cs
Show resolved
Hide resolved
tmds
approved these changes
Apr 8, 2021
stephentoub
approved these changes
Apr 9, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe this is the root of the issue in #50380.
Other sync socket calls (send, recv, etc) call ShouldRetrySyncOperation in order to distinguish between a timeout on a sync socket vs EAGAIN on a socket that's been forced into nonblocking mode. The Connect operation isn't, which means that we are misinterpreting some timeouts as meaning that the socket is now nonblocking.
Fixes #50380