Add check for JsonConverterFactories returning JsonConverterFactories (#50219) #50329
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SkiFoD
requested review from
eiriktsarpalis,
jozkee,
layomia and
steveharter
as code owners
ghost
added
the
|
Tagging subscribers to this area: @eiriktsarpalis, @layomia Issue DetailsThere is added check that Create Converter can't return JsonConverterFactory
|
eiriktsarpalis
changed the title
SkiFoD
force-pushed
the
skifod/issue-50219
branch
from
1e8a915 to
2ccfbcf
Compare
eiriktsarpalis
approved these changes
Mar 28, 2021
Member
eiriktsarpalis
left a comment
eiriktsarpalis
left a comment
There was a problem hiding this comment.
Thank you for your contribution!
Fix #50219.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is added check that Create Converter can't return JsonConverterFactory