Clean up string formatting in a variety of places #50267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

stephentoub merged 1 commit into dotnet:main from stephentoub:stringformat

Apr 5, 2021

Member

stephentoub commented Mar 26, 2021

Mostly just replacing string.Format calls with equivalent interpolated string uses. In some cases, I replaced lots of string creations with a StringBuilder or equivalent.

ghost added the area-Meta label

benaadams reviewed

View reviewed changes

src/coreclr/System.Private.CoreLib/src/System/Reflection/CustomAttribute.cs Outdated Show resolved Hide resolved

benaadams reviewed

View reviewed changes

...braries/System.Diagnostics.FileVersionInfo/src/System/Diagnostics/FileVersionInfo.Windows.cs Outdated Show resolved Hide resolved

benaadams reviewed

View reviewed changes

src/libraries/System.Private.CoreLib/src/System/Reflection/CustomAttributeTypedArgument.cs Outdated Show resolved Hide resolved

benaadams reviewed

View reviewed changes

src/libraries/System.Threading.Tasks.Dataflow/src/Base/DataflowBlock.cs Outdated Show resolved Hide resolved

benaadams reviewed

View reviewed changes

src/libraries/System.Threading.Tasks.Dataflow/src/Base/DataflowBlock.cs Outdated Show resolved Hide resolved

stephentoub force-pushed the stringformat branch from 444d8eb to 67001df Compare

March 26, 2021 03:05

Member Author

stephentoub commented Mar 26, 2021

Thanks, @benaadams.

stephentoub force-pushed the stringformat branch 2 times, most recently from 36172ca to 866bc9a Compare

March 26, 2021 13:58


          Clean up string formatting in a variety of places

f7504de

Mostly just replacing string.Format calls with equivalent interpolated string uses.  In some cases, I replaced lots of string creations with a StringBuilder or equivalent.

stephentoub force-pushed the stringformat branch from 866bc9a to f7504de Compare

March 26, 2021 15:11

stephentoub merged commit 0c79392 into dotnet:main

stephentoub deleted the stringformat branch

April 5, 2021 03:16

ghost locked as resolved and limited conversation to collaborators

karelz added this to the 6.0.0 milestone

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels