Return DiaSymReader library for cross-arch crossgen to Runtime package #50251
Conversation
AntonLapounov
changed the title
|
@jeffschwMSFT Who can authorize this PR to unblock aspnetcore? |
|
Anyone should be able to. Adding @Anipik if there is any permissions issues. Do you have a gist/pull with the necessary changes? |
|
I am seeing "Merging is blocked. The base branch restricts merging to authorized users. You’re not authorized to merge this pull request." for this PR. |
|
@Anipik Could you please merge this? |
|
Adding @ViktorHofer as @Anipik is out of office. Who has merge permissions in preview3? |
|
@wtgodbe do you have preview branch push rights in this repo❔ |
I do not, though I probably should in case I ever need to cover for a 5.0/6.0 build - CC @mmitche who probably does have permissions |
|
@mmitche @jeffschwMSFT @jaredpar any other ideas who has admin rights in this repo❔ Or, is this waiting for an ask-mode dance❔ |
|
Apparently I do, and I just merged. |
|
Much appreciated. This should unblock dotnet/aspnetcore#31255 🎉 |
ghost
locked as resolved and limited conversation to collaborators
6 participants
Merge #50149 to preview3 branch.
Customer Impact
The
Microsoft.NETCore.App.Runtime.win-armpackage misses theMicrosoft.DiaSymReader.Native.x86.dlllibrary required by the x86-hostedcrossgen.exein order to generate PDBs in the cross-architecture compilation scenario. Similarly, theMicrosoft.NETCore.App.Runtime.win-arm64package misses theMicrosoft.DiaSymReader.Native.amd64.dlllibrary required by the x64-hostedcrossgen.exe. This blocks integration to AspNetCore repo.Testing
The fix has been tested in the main branches of Runtime and AspNetCore repos.
Risk
No known risk.