Delete pEmitter after using it in ceeload #50242
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
jkotas
reviewed
Mar 25, 2021
src/coreclr/vm/ceeload.cpp
Outdated
Member
There was a problem hiding this comment.
The VM convention is to use NewHolder<ProfileEmitter> for cleanup in situations like this one. Could you please switch to that?
omajid
force-pushed
the
ceeload-pewriter-leak
branch
from
2e78b90 to
2b20b4c
Compare
It seems like we are allocating memory, but never releasing it.
omajid
force-pushed
the
ceeload-pewriter-leak
branch
from
2b20b4c to
f97e6c5
Compare
clamp03
added a commit
to clamp03/runtime
that referenced
this pull request
Mar 31, 2021
pEmitter is not assigned in dotnet#50242
jkotas
pushed a commit
that referenced
this pull request
Mar 31, 2021
pEmitter is not assigned in #50242
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems like we are allocating memory, but never releasing it.
Allocate pEmitter closer to where it's used, skipping a FailIfThrow as well.