Skip to content

Seal internal types in libraries #50225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
stephentoub merged 1 commit into from
Mar 26, 2021
Merged

Seal internal types in libraries #50225

stephentoub merged 1 commit into from
Mar 26, 2021

Conversation

@stephentoub
Copy link
Member

@stephentoub stephentoub commented Mar 25, 2021

Contributes to #49944

@stephentoub stephentoub added this to the 6.0.0 milestone Mar 25, 2021
@stephentoub stephentoub requested a review from a team March 25, 2021 03:54
@dotnet dotnet deleted a comment Mar 25, 2021
eiriktsarpalis
eiriktsarpalis approved these changes Mar 25, 2021
View reviewed changes
Copy link
Member

@eiriktsarpalis eiriktsarpalis left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Presumably the new-api-needs-documentation label was applied because of the changed internal classes in some of the reference sources?

@stephentoub
Copy link
Member Author

stephentoub commented Mar 25, 2021

Presumably the new-api-needs-documentation label was applied because of the changed internal classes in some of the reference sources?

Yeah, I believe it's added automatically for any changes to files under ref.

This was referenced Mar 25, 2021
Closed
Closed
@stephentoub stephentoub merged commit 0817e74 into dotnet:main Mar 26, 2021
@stephentoub stephentoub deleted the sealedinternal branch March 26, 2021 00:50
@ghost ghost locked as resolved and limited conversation to collaborators Apr 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@eiriktsarpalis eiriktsarpalis eiriktsarpalis approved these changes

@jozkee jozkee Awaiting requested review from jozkee

@layomia layomia Awaiting requested review from layomia

@steveharter steveharter Awaiting requested review from steveharter

Assignees

No one assigned

Labels

area-Meta

Projects

None yet

Milestone

6.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@stephentoub @eiriktsarpalis