Reduce cost of CreateSecKeyAndSecWebSocketAccept in ClientWebSocket #49831
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/ncl Issue DetailsThis isn't a big deal as it's once per websocket connection, but it annoys me every time I see the unnecessary waste in a trace 😄, so I'm scratching an itch. Previously this would allocate:
Now, it only allocates (2) and (6).
|
This isn't a big deal as it's once per websocket connection, but it annoys me every time I see the unnecessary waste in a trace. Previously this would allocate: 1. A byte[] for the bytes from the guid 2. A base64-encoded string for (1) 3. A string concatenating (2) and the known server guid 4. A byte[] containing the bytes from (3) 5. A byte[] containing the SHA1-hashed bytes of (4) 6. A base64-encoded string of (5) Now, it only allocates (2) and (6).
Member
|
@BrennanConroy did the same on the server side 👍🏾 |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This isn't a big deal as it's once per websocket connection, but it annoys me every time I see the unnecessary waste in a trace 😄, so I'm scratching an itch.
Previously this would allocate:
Now, it only allocates (2) and (6).