Skip to content

Conversation

@ericstj
Copy link
Member

@ericstj ericstj commented Mar 18, 2021

Replaces #49781

@ghost
Copy link

ghost commented Mar 18, 2021

Tagging subscribers to this area: @Anipik, @safern, @ViktorHofer
See info in area-owners.md if you want to be subscribed.

Issue Details

Replaces #49781

Author: ericstj
Assignees: -
Labels:

area-Infrastructure-libraries

Milestone: -

@GrabYourPitchforks
Copy link
Member

I am totally underqualified to review this PR. :)

But out of curiosity, I wonder if it would make sense to start performing cleanup of this as RIDs drop off. For instance, netcoreapp2.0 and netcoreapp3.0 are out of support, netcoreapp2.1 will be out of support by the time this wave ships, and so on. It doesn't affect this PR in any way, but it makes me wonder if we should do a grand pass of this and all of our ref\*.csproj and src\*.csproj files.

@ViktorHofer
Copy link
Member

It doesn't affect this PR in any way, but it makes me wonder if we should do a grand pass of this and all of our ref*.csproj and src*.csproj files.

After removing harvested assets, this would be the next iteration of trimming out package assets that aren't applicable to modern workloads anymore.

@GrabYourPitchforks
Copy link
Member

I kicked the staging step again, but CI looked green otherwise.

@ericstj
Copy link
Member Author

ericstj commented Mar 18, 2021

But out of curiosity, I wonder if it would make sense to start performing cleanup

This whole validation process should be wholesale replaced with the shipping functionality that @safern and @anpik are working on. PackageIndex, SupportedFramework, etc will go away 🤞

@GrabYourPitchforks
Copy link
Member

@ericstj @safern Is there any other signoff or validation we're waiting for?

@ericstj
Copy link
Member Author

ericstj commented Mar 18, 2021

Nope, this looks good.

@ericstj ericstj merged commit f58730b into dotnet:main Mar 18, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Apr 17, 2021
@karelz karelz added this to the 6.0.0 milestone May 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants