Skip to content

Conversation

@AntonLapounov
Copy link
Member

Update the Microsoft.DiaSymReader.Native package to get the ARM64 version of the native DLL required by the ARM64-hosted crossgen2. @dotnet/crossgen-contrib

Copy link
Member

@trylek trylek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you!

@AntonLapounov AntonLapounov merged commit 7efce05 into dotnet:main Mar 18, 2021
@AntonLapounov AntonLapounov deleted the UpdateDiaSymReaderNative branch March 18, 2021 01:26
@KalleOlaviNiemitalo
Copy link

KalleOlaviNiemitalo commented Mar 18, 2021

The license terms for Microsoft.DiaSymReader.Native 16.9.0-beta1.21055.5 are a bit different from the ones for 1.7.0. I didn't compare them in detail but there are new sentences about ".js files" at least. Should src/installer/pkg/LICENSE-MSFT.TXT be modified likewise?

@AntonLapounov
Copy link
Member Author

@KalleOlaviNiemitalo Thank you for catching and reporting that difference. I will follow up on that.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants