Change prejit instrumentation default back to block profiling #49441
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both crossgen1 and crossgen2 currently reject schemas that contain edge profile counters. Change the jit defaults back to block profiling when prejitting. See notes in dotnet#49267.
ghost
added
the
area-CodeGen-coreclr
Member
Author
|
We could probably update the R2R paths to support edge counters, but I'm not sure it is worth the trouble, as we don't plan to use prejit instrumentation going forward. cc @davidwrighton |
EgorBo
reviewed
Mar 10, 2021
BruceForstall
approved these changes
Mar 10, 2021
clamp03
approved these changes
Mar 11, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both crossgen1 and crossgen2 currently reject schemas that contain edge profile
counters. Change the jit defaults back to block profiling when prejitting.
See notes in #49267.