Skip to content

Fix https://github.com/dotnet/runtime/issues/46698. #49293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vargaz merged 1 commit into from
Mar 8, 2021
Merged

Fix https://github.com/dotnet/runtime/issues/46698. #49293

vargaz merged 1 commit into from
Mar 8, 2021

Conversation

@vargaz
Copy link
Contributor

@vargaz vargaz commented Mar 8, 2021 •
edited by marek-safar
Loading

Fixes #46698

@ghost ghost added the area-Codegen-JIT-mono label Mar 8, 2021
@radical
Copy link
Member

radical commented Mar 8, 2021

Can we add a test for this too?

@vargaz
Copy link
Contributor Author

vargaz commented Mar 8, 2021 •
edited
Loading

The failure can be observed in the class libs aot tests.

@vargaz vargaz merged commit 3060060 into dotnet:main Mar 8, 2021
@vargaz vargaz deleted the fix-46698 branch March 8, 2021 20:10
@ghost ghost locked as resolved and limited conversation to collaborators Apr 7, 2021
@karelz karelz added this to the 6.0.0 milestone May 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lambdageek lambdageek Awaiting requested review from lambdageek

@SamMonoRT SamMonoRT Awaiting requested review from SamMonoRT

1 more reviewer

@CoffeeFlux CoffeeFlux CoffeeFlux approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-Codegen-JIT-mono

Projects

None yet

Milestone

6.0.0

Development

Successfully merging this pull request may close these issues.

wasm AOT library test failure - condition <disabled> not met

4 participants

@vargaz @radical @CoffeeFlux @karelz