Reset assignedInterval during verifyFinalAllocation #49286
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix failures exposed by EHWriteThru: https://dev.azure.com/dnceng/public/_build/results?buildId=1021926&view=ms.vss-test-web.build-test-results-tab&runId=31791570&resultId=180705&paneView=dotnet-dnceng.dnceng-build-release-tasks.helix-test-information-tab https://helixre8s23ayyeko0k025g8.blob.core.windows.net/dotnet-runtime-refs-pull-47307-head-ad03bd78ebf7456dbe/System.Memory.Tests/console.387c2cf0.log?sv=2019-07-07&se=2021-03-24T01%3A36%3A31Z&sr=c&sp=rl&sig=hPD%2B625ykQtQRVKnl3pCZzTEiI5hXzrqZtIPgo6Wc74%3D
Fixes errors like this: https://dev.azure.com/dnceng/public/_build/results?buildId=1024357&view=ms.vss-test-web.build-test-results-tab&runId=31848698&resultId=181011&paneView=dotnet-dnceng.dnceng-build-release-tasks.helix-test-information-tab https://helixre8s23ayyeko0k025g8.blob.core.windows.net/dotnet-runtime-refs-pull-47307-head-2f177492e7644d448d/System.Management.Tests/console.5337e574.log?sv=2019-07-07&se=2021-03-25T09%3A27%3A01Z&sr=c&sp=rl&sig=aBfB4tstmjMyucEadkhaFxtWdog3teT32PvzPAS4Vv4%3D
ghost
added
the
area-CodeGen-coreclr
Contributor
Author
|
@dotnet/jit-contrib |
Member
|
Code formatting issue on Linux? |
Contributor
Author
Oh yes, fixed. |
AndyAyersMS
approved these changes
Mar 8, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My latest changes to EH Var for single defs exposed 2 more issues where we were not resetting the
assignedIntervalof a assigned reg:RefTypeDef, if an interval doesn't get assigned to a new register, then reset theassignedIntervalof theregRecordthat is currently assigned to that interval.RefTypeDef, if an interval got assigned to a different register than the originalassignRegof that interval and if that refposition is spilled immediately, then reset theassignedIntervalof suchregRecord.Both of the above scenarios were exposed because they were EH Vars. In
verifyFinalAllocation(), there are multiple places where we check forRefTypeDefand take action and I looked into consolidating all the logic at single place, but I was not sure if it will regress in the way we print the "Final allocation table". Hence, to honor the time, I went ahead and did the spot fixing of these 2 scenarios, but in future, will try to refactor various scenarios.Fixes errors: