Use unknown placeholder for collectible class typehandle #48707
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
instead of null, so that we won't over-estimate likelihood of other types at a call site where we see both collectible and non-collectible types. Addresses part of dotnet#48549.
ghost
added
the
area-CodeGen-coreclr
Member
Author
Member
Author
|
@davidwrighton can you take a look? -- this is the simple version. |
Member
Author
|
@dotnet/jit-contrib anyone up for taking a look? It is a simple change. |
EgorBo
approved these changes
Mar 3, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instead of null, so that we won't over-estimate likelihood of other types at a
call site where we see both collectible and non-collectible types.
Addresses part of #48549.