[coop] Enter GC Unsafe mode in mono_gc_init_finalizer_thread#48465
Merged
lambdageek merged 1 commit intodotnet:masterfrom Feb 18, 2021
Merged
Conversation
when lazy thread creation is used, this external API function is called from a thread in GC Safe mode, so enter GC Unsafe before calling runtime functions. Fixes a double transition to GC Safe in mono_gc_pthread_create. Fixes dotnet#47121
lambdageek
requested review from
CoffeeFlux,
thaystg and
vargaz
as code owners
|
Tagging subscribers to this area: @CoffeeFlux Issue DetailsWhen lazy thread creation is used, this external API function is called from a thread in GC Safe mode, so enter GC Unsafe before calling runtime functions. Fixes a double transition to GC Safe in Fixes #47121
|
CoffeeFlux
approved these changes
Feb 18, 2021
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When lazy thread creation is used, this external API function is called from a thread in GC Safe mode, so enter GC Unsafe before calling runtime functions.
Fixes a double transition to GC Safe in
mono_gc_pthread_create.Fixes #47121