Create LclVarAddr with the correct type. #48451
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandreenko
added
area-CodeGen-coreclr
Merged
EgorBo
reviewed
Feb 18, 2021
|
|
||
| location->SetOper(addrForm(locationOp)); | ||
| location->gtType = TYP_BYREF; | ||
| location->gtType = address->TypeGet(); |
Member
There was a problem hiding this comment.
Suggested change
| location->gtType = address->TypeGet(); | |
| location->ChangeType(address->TypeGet()); |
Contributor
Author
|
This PR reveals several other issues, a bigger fix is needed, will do it in another PR but it is currently blocked as well. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have such optimization for lclVar addresses that we pass to calls (in
fgMorphArgs):so
ADDR->gtTypecould be a better type thanTYP_BYREF.