[mono] Enable arm64 intrinsic tests #48397
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imhameed
force-pushed
the
mono-enable-arm64-intrinsics-tests
branch
from
2d5c210 to
c05e4af
Compare
imhameed
force-pushed
the
mono-enable-arm64-intrinsics-tests
branch
from
72d0d5e to
8b47a48
Compare
imhameed
added
area-Codegen-LLVM-mono
runtime-mono
imhameed
requested review from
CoffeeFlux,
SamMonoRT,
lambdageek,
thaystg and
vargaz
as code owners
imhameed
force-pushed
the
mono-enable-arm64-intrinsics-tests
branch
3 times, most recently
from
10c4bfc to
13c34a0
Compare
imhameed
force-pushed
the
mono-enable-arm64-intrinsics-tests
branch
from
710ab1b to
1e5d147
Compare
Contributor
Author
|
The arm64 failures are relevant, although I haven't (yet) reproduced the exact same failure on an actual arm64 Linux machine |
imhameed
force-pushed
the
mono-enable-arm64-intrinsics-tests
branch
2 times, most recently
from
620bc18 to
bd1e26f
Compare
imhameed
force-pushed
the
mono-enable-arm64-intrinsics-tests
branch
from
bd1e26f to
b760ded
Compare
This was referenced Mar 1, 2021
lambdageek
reviewed
Mar 1, 2021
lambdageek
reviewed
Mar 1, 2021
Member
lambdageek
left a comment
lambdageek
left a comment
There was a problem hiding this comment.
LGTM, but I'm not an intrinsics expert
vargaz
reviewed
Mar 2, 2021
vargaz
reviewed
Mar 2, 2021
vargaz
approved these changes
Mar 2, 2021
…ume base/crc/crypto/simd for arm64 and sse-sse4.2/popcnt/lzcnt/bmi/bmi2 for amd64
…trings are passed through to llc)
…ction that hasn't yet been implemented
…translating an intrinsic that is unimplemented. Eagerly fail to translate Vector64 AdvSimd.Abs. Bump MONO_AOT_FILE_VERSION, as suggested by jit-icall-reg.h
This reverts commit a6b13de141adc462de901182d1ca123010842dba.
…otSupportedException for recursive calls outside of functions contained within intrinsic-related namespaces/classes
…ividual functions
imhameed
force-pushed
the
mono-enable-arm64-intrinsics-tests
branch
from
b2d0d5d to
ed0fa19
Compare
58 tasks
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change:
Removes
basefrom the list of LLVM-style attributes supported by the AOTcompiler.
Adds another icall that raises a
PlatformNotSupportedException, and bumpsthe AOT file format version number.
Makes unsupported intrinsics raise a
PlatformNotSupportedExceptionregardless of the codegen backend used: AOT/JIT/interpreter, mini/LLVM.
Enables formerly-disabled tests in
JIT/HardwareIntrinsics/Arm/**/*.Incrementally consolidates duplicated arm64/amd64 intrinsics-handling code.
Intrinsic "group" lookup is now table-driven, and most hardware intrinsic
lookup logic happens in one place.