Skip to content

Try full benchmark run for SPMI collection #48390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kunalspathak wants to merge 2 commits into from
Closed

Try full benchmark run for SPMI collection #48390

kunalspathak wants to merge 2 commits into from

Conversation

@kunalspathak
Copy link
Contributor

@kunalspathak kunalspathak commented Feb 17, 2021

No description provided.

@ghost ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Feb 17, 2021
@kunalspathak kunalspathak mentioned this pull request Feb 17, 2021
Merged
@BruceForstall
Copy link
Contributor

BruceForstall commented Feb 18, 2021

@kunalspathak Is this close to getting merged?

I'm worried that with all the recent JIT-EE version changes, when you trigger this PR and publish new collections, it might be doing builds/tests not against current master -- at least, some behavior I'm seeing might indicate I'm not seeing the right collection MCH format.

@kunalspathak
Copy link
Contributor Author

kunalspathak commented Feb 18, 2021

We might need more time to understand why benchmark mch don't show TIER flags. See #48281 (comment) and #48281 (comment). May be you should merge your changes in #48375 so we can at least get Linux x64 collection back.

@BruceForstall
Copy link
Contributor

BruceForstall commented Feb 18, 2021

Ok. Then maybe you should temporarily change the JIT/EE GUID in this PR while you're iterating on it. Or maybe you should change it anyway, to force a new collection when you eventually merge.

@JulieLeeMSFT JulieLeeMSFT added this to the 6.0.0 milestone Feb 18, 2021
Base automatically changed from master to main March 1, 2021 09:07
@kunalspathak
Copy link
Contributor Author

kunalspathak commented Mar 9, 2021

For now I am closing this PR and might reopen specifically if we want to enable dynamic PGO flags.

@ghost ghost locked as resolved and limited conversation to collaborators Apr 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@kunalspathak kunalspathak

Labels

area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Milestone

6.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@kunalspathak @BruceForstall @JulieLeeMSFT